Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress codeowner notifications for package bumps #3654

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Feb 17, 2025

Motivation

Hubcap identifies new package releases and opens a PR against this repo, which is automatically merged. Because the DX team has responsibility for the repo per the new codeowners file, we are now getting notified on every new package release. We don't need to know!

Fix

Specify the codegenned directories under data/packages/ as having no owner, so that DX doesn't get emailed about things like #3653. (Per https://stackoverflow.com/a/74964396/14007029)

Alternative option, I guess

Each DX employee sets up gmail rules to auto-archive the unwanted emails

@joellabes joellabes requested a review from Cr0n1c February 17, 2025 19:08
@joellabes joellabes requested a review from cmcarthur as a code owner February 17, 2025 19:08
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:08pm

Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joellabes -- agree that this is a worthy exception

@joellabes joellabes merged commit dd965e2 into master Feb 17, 2025
9 checks passed
@joellabes joellabes deleted the joellabes-patch-1 branch February 17, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants